From 285318ada382b096e9cf162c872983cc6531924f Mon Sep 17 00:00:00 2001 From: Sergey Tatarintsev Date: Fri, 10 May 2024 12:49:29 +0200 Subject: [PATCH] Ensure that test actually fails when things are broken Test could never actually fail, because the only thing it doess is checks that `test_indicator` element exists and that element was shown regardless of test result. Fixed that by giving different test ids to success and failure indicators. At the moment, tests deliberately fail because custom databases are not supported. --- .github/workflows/update-and-publish.yml | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/.github/workflows/update-and-publish.yml b/.github/workflows/update-and-publish.yml index a079545..ed00f03 100644 --- a/.github/workflows/update-and-publish.yml +++ b/.github/workflows/update-and-publish.yml @@ -7,7 +7,7 @@ on: type: string required: true version: - description: npm version to publish + description: client version to update to and publish type: string required: true secrets: @@ -19,10 +19,14 @@ on: inputs: npmTag: description: npm tag to publish to - type: string + type: choice + options: + - latest + - dev + - integration required: true version: - description: npm version to publish + description: client version to update to and publish type: string required: true @@ -93,7 +97,9 @@ jobs: run: yarn npm publish --tag "$NPM_TAG" - name: Push - run: git push origin main + env: + GITHUB_REF: ${{ github.ref }} + run: git push origin "$GITHUB_REF" notify-on-failure: name: Notify on publish failure