Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(driver-adapters): remove TypeScript from "pglite-node-basic" #5231

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Jul 16, 2024

This PR removes any TypeScript pre-processing from the driver-adapters/pglite-node-basic test suite.
This was done to work around a ts-jest regression which caused the failure:

ReferenceError: exports is not defined

Context: see Slack.

@jkomyno jkomyno requested review from janpio and a team as code owners July 16, 2024 09:54
@jkomyno jkomyno requested review from SevInf and Druue and removed request for a team, janpio and Druue July 16, 2024 09:54
@jkomyno jkomyno self-assigned this Jul 16, 2024
@SevInf
Copy link
Contributor

SevInf commented Jul 16, 2024

Let's wait until it is green and merge

@SevInf SevInf merged commit c38ecbd into dev Jul 16, 2024
54 checks passed
@SevInf SevInf deleted the feat/remove-ts-from-pglite-node-basic branch July 16, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants