Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: Remove useless generate #5074

Merged
merged 1 commit into from
Jun 10, 2024
Merged

pkg: Remove useless generate #5074

merged 1 commit into from
Jun 10, 2024

Conversation

SevInf
Copy link
Contributor

@SevInf SevInf commented Jun 10, 2024

This generate call is not supposed to work - there is no schema to
generate from where it is called. It was working before because generate
incorrectly thought it's called from a postinstall hook and produced
soft error instead.

Close prisma/team-orm#1183

This `generate` call is not supposed to work - there is no schema to
generate from where it is called. It was working before because generate
incorrectly thought it's called from a postinstall hook and produced
soft error instead.

Close prisma/team-orm#1183
@SevInf SevInf marked this pull request as ready for review June 10, 2024 13:56
@SevInf SevInf requested review from janpio and a team as code owners June 10, 2024 13:56
@SevInf SevInf requested review from aqrln and Druue and removed request for a team June 10, 2024 13:56
@Druue
Copy link

Druue commented Jun 10, 2024

This is pending the following PR, yeah?
prisma/prisma#24484

@Jolg42 Jolg42 added this to the 5.16.0 milestone Jun 10, 2024
@SevInf SevInf merged commit 62a17e4 into dev Jun 10, 2024
38 checks passed
@SevInf SevInf deleted the fix/pkg branch June 10, 2024 14:39
@SevInf
Copy link
Contributor Author

SevInf commented Jun 10, 2024

@Druue they are part of same bunch, but can be merged independently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants