Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces usage of User with Bidder #61

Merged
merged 8 commits into from
Dec 26, 2023
Merged

Conversation

ckartik
Copy link
Contributor

@ckartik ckartik commented Dec 19, 2023

  • Replaces the usage of user with bidder across the code.

@ckartik ckartik requested review from kant777 and shaspitz December 19, 2023 23:04
@kant777
Copy link
Contributor

kant777 commented Dec 19, 2023

Need to update this as well https://github.com/primevprotocol/mev-commit/blob/main/pkg/abi/abi.go#L1244 and run the integration test before merging this in

README.md Show resolved Hide resolved
Copy link
Contributor

@kant777 kant777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update this as well https://github.com/primevprotocol/mev-commit/blob/main/pkg/abi/abi.go#L1244 and run the integration test before merging this in

@ckartik
Copy link
Contributor Author

ckartik commented Dec 21, 2023

Made the Update here

contracts/BidderRegistry.sol Outdated Show resolved Hide resolved
contracts/BidderRegistry.sol Outdated Show resolved Hide resolved
contracts/BidderRegistry.sol Outdated Show resolved Hide resolved
contracts/BidderRegistry.sol Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@ckartik ckartik force-pushed the ckaritk/update-user-to-bidder branch from 371a685 to 51bd991 Compare December 26, 2023 20:30
@ckartik ckartik removed the request for review from shaspitz December 26, 2023 20:46
@ckartik ckartik merged commit cf30697 into main Dec 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants