Move blankslate styles to PVC
#1584
Conversation
🦋 Changeset detectedLatest commit: 70a2a54 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -3,3 +3,4 @@ | |||
| @import "./alpha/banner.pcss"; | |||
| @import './alpha/segmented_control.pcss'; | |||
| @import "./beta/button.pcss"; | |||
| @import "./beta/blankslate.pcss"; | |||
There was a problem hiding this comment.
If we import it here (to be used in Lookbook), I guess we'll have to expand the import on dotcom. Like https://github.com/github/github/pull/245966.
Or an alternative would be to not import blankslate here, but update the Lookbook import to something like:
- *= require @primer/css/dist/blankslate.css
+ *= require ../../../../../app/components/primer/beta/blankslate.cssBut I haven't figured out the exact relative path.
There was a problem hiding this comment.
nvm.. We decided to not expand the PVC imports on dotcom. It might cause regression changing the source order. But we'll have to do that eventually anyways.
Description
This is part of #1342 and adds the
blankslatestyles from PCSS. There should be no visual changes. See this commit a263494 for the diff of migrating from.scssto.pcss.👀 Preview
Closes https://github.com/github/primer/issues/1497
Integration
Yes, this line should be removed on dotcom:
- @import '@primer/css/blankslate/blankslate.scss';Merge checklist
Added/updated testsAdded/updated documentationAdded/updated previewsIf you can't spot a difference 👉 good!