„New“ menu always shown on iPad

[mr-manuel]

Describe the bug
The „new“ menu is always shown.

To Reproduce
Steps to reproduce the behavior:

1. Login to GitHub on an iPad in Firefox
2. See the open menu

Expected behavior
The menu should only be shown, if opened.

Screenshots

Tablet (please complete the following information):

• Device: iPad Pro 11“ 2020
• OS: iPadOs 17.0
• Browser Firefox
• Version 115.1

Additional context
In Safari it works. I already cleared the cache of Firefox and reinstalled the app.

[mr-manuel]

since a few days one more menu is constantly shown…

[lesliecdubs]

Thanks for reporting!

@keithamus we were thinking you might have some insight here as we think this is a popover compatibility issue in Firefox. Do you happen to know the ETA for that support? If it's going to be a while, is there a polyfill for Firefox or potentially a CSS solution we could make sure is set up to work properly?

[keithamus]

This is indeed a Firefox compatibility issue with popover on iOS/iPad OS 17. This is because Safari 17 has enabled popover, which includes applying the @support rules for :popover-open, but sadly it doesn't enable the popover functionality for web views (of which Firefox is one).

This is fixed by oddbird/popover-polyfill#137 which we'll merge when it is merged/released upstream.

[lesliecdubs]

Thanks. Moving this to the backlog for now to revisit and resolve once the polyfill support has landed.

[mr-manuel]

Should the change already be visible?

[keithamus]

Not just yet, I'll come back here and let you know when we're deploying.

[keithamus]

This is the WebKit bug for reference: https://bugs.webkit.org/show_bug.cgi?id=263405.

[keithamus]

Following up as promised; the patch just went out and this is now resolved @mr-manuel.

[mr-manuel]

Thank you! I confirm that this is fixed now :-)