From c01d5c803cf18cac2f4ba0409e9745bf42d09352 Mon Sep 17 00:00:00 2001 From: Cameron Dutro Date: Wed, 15 Jan 2025 14:56:35 -0800 Subject: [PATCH 1/2] Avoid TypeError in PageLayout checking document.body --- .changeset/lazy-jars-leave.md | 5 +++++ packages/react/src/PageLayout/PageLayout.tsx | 6 +++--- 2 files changed, 8 insertions(+), 3 deletions(-) create mode 100644 .changeset/lazy-jars-leave.md diff --git a/.changeset/lazy-jars-leave.md b/.changeset/lazy-jars-leave.md new file mode 100644 index 00000000000..22849369cf2 --- /dev/null +++ b/.changeset/lazy-jars-leave.md @@ -0,0 +1,5 @@ +--- +"@primer/react": patch +--- + +Avoid accessing properties of potentially null document.body in PageLayout diff --git a/packages/react/src/PageLayout/PageLayout.tsx b/packages/react/src/PageLayout/PageLayout.tsx index ee166fb5bce..c2780a1c28d 100644 --- a/packages/react/src/PageLayout/PageLayout.tsx +++ b/packages/react/src/PageLayout/PageLayout.tsx @@ -364,13 +364,13 @@ const VerticalDivider: React.FC { @@ -378,7 +378,7 @@ const VerticalDivider: React.FC Date: Thu, 16 Jan 2025 14:36:39 -0800 Subject: [PATCH 2/2] Make eslint happy --- packages/react/src/PageLayout/PageLayout.tsx | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/packages/react/src/PageLayout/PageLayout.tsx b/packages/react/src/PageLayout/PageLayout.tsx index c2780a1c28d..f1240338f66 100644 --- a/packages/react/src/PageLayout/PageLayout.tsx +++ b/packages/react/src/PageLayout/PageLayout.tsx @@ -364,13 +364,15 @@ const VerticalDivider: React.FC { @@ -378,7 +380,8 @@ const VerticalDivider: React.FC