From 48b44707bf8cda7b48745d628b998b88cd1e4316 Mon Sep 17 00:00:00 2001 From: Tyler Jones Date: Thu, 2 Jan 2025 16:42:57 -0500 Subject: [PATCH 1/4] unmask datatable section --- e2e/components/DataTable.test.ts | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/e2e/components/DataTable.test.ts b/e2e/components/DataTable.test.ts index 3fe694ccc5a..94631bdf381 100644 --- a/e2e/components/DataTable.test.ts +++ b/e2e/components/DataTable.test.ts @@ -63,15 +63,7 @@ test.describe('DataTable', () => { }) // Default state - expect( - await page.screenshot({ - mask: await page - .locator('td', { - has: page.locator('relative-time'), - }) - .all(), - }), - ).toMatchSnapshot(`DataTable.${story.title}.${theme}.png`) + expect(await page.screenshot()).toMatchSnapshot(`DataTable.${story.title}.${theme}.png`) }) test('axe @aat', async ({page}) => { From 05222642b107b41040083cd421ea03ec277b1683 Mon Sep 17 00:00:00 2001 From: Tyler Jones Date: Tue, 7 Jan 2025 16:54:33 -0500 Subject: [PATCH 2/4] Behaviors bump, test canary package --- package-lock.json | 17 ++++++++++++----- packages/react/package.json | 2 +- 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/package-lock.json b/package-lock.json index f2fa4b776f7..7034f4fa55e 100644 --- a/package-lock.json +++ b/package-lock.json @@ -62,7 +62,7 @@ "name": "example-app-router", "version": "0.0.0", "dependencies": { - "@primer/react": "37.8.0", + "@primer/react": "37.9.0", "next": "^14.2.15", "react": "^18.3.1", "react-dom": "^18.3.1", @@ -81,7 +81,7 @@ "react-dom": "^18.3.1" }, "devDependencies": { - "@primer/react": "37.8.0", + "@primer/react": "37.9.0", "@types/react": "^18.3.11", "@types/react-dom": "^18.3.0", "@typescript-eslint/eslint-plugin": "^7.11.0", @@ -100,7 +100,7 @@ "version": "0.0.0", "dependencies": { "@primer/octicons-react": "^19.9.0", - "@primer/react": "37.8.0", + "@primer/react": "37.9.0", "clsx": "^1.2.1", "next": "^14.2.15", "react": "^18.3.1", @@ -6041,6 +6041,7 @@ }, "node_modules/@primer/behaviors": { "version": "1.7.2", + "dev": true, "license": "MIT" }, "node_modules/@primer/css": { @@ -30667,14 +30668,14 @@ }, "packages/react": { "name": "@primer/react", - "version": "37.8.0", + "version": "37.9.0", "license": "MIT", "dependencies": { "@github/relative-time-element": "^4.4.3", "@github/tab-container-element": "^4.8.0", "@lit-labs/react": "1.2.1", "@oddbird/popover-polyfill": "^0.4.4", - "@primer/behaviors": "^1.7.2", + "@primer/behaviors": "0.0.0-20250107215005", "@primer/live-region-element": "^0.7.1", "@primer/octicons-react": "^19.13.0", "@primer/primitives": "9.x || 10.x", @@ -30824,6 +30825,12 @@ } } }, + "packages/react/node_modules/@primer/behaviors": { + "version": "0.0.0-20250107215005", + "resolved": "https://registry.npmjs.org/@primer/behaviors/-/behaviors-0.0.0-20250107215005.tgz", + "integrity": "sha512-LF5qqziUObrMI55qt6ZTCWW7ysyDqMcyZIYZ63Fdi/wmcJYtsyy5t3bO1mVB1OGBtvTRBmKzJ5pofs4NUUAQPQ==", + "license": "MIT" + }, "packages/react/node_modules/@primer/primitives": { "version": "10.2.0", "license": "MIT" diff --git a/packages/react/package.json b/packages/react/package.json index c97c61ce13a..d667574cbfc 100644 --- a/packages/react/package.json +++ b/packages/react/package.json @@ -82,7 +82,7 @@ "@github/tab-container-element": "^4.8.0", "@lit-labs/react": "1.2.1", "@oddbird/popover-polyfill": "^0.4.4", - "@primer/behaviors": "^1.7.2", + "@primer/behaviors": "0.0.0-20250107215005", "@primer/live-region-element": "^0.7.1", "@primer/octicons-react": "^19.13.0", "@primer/primitives": "9.x || 10.x", From f96ef9abe06c1c9d00421e4efb63f05b855788d3 Mon Sep 17 00:00:00 2001 From: Tyler Jones Date: Tue, 7 Jan 2025 16:56:59 -0500 Subject: [PATCH 3/4] Remove unnecessary change --- e2e/components/DataTable.test.ts | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/e2e/components/DataTable.test.ts b/e2e/components/DataTable.test.ts index 94631bdf381..3fe694ccc5a 100644 --- a/e2e/components/DataTable.test.ts +++ b/e2e/components/DataTable.test.ts @@ -63,7 +63,15 @@ test.describe('DataTable', () => { }) // Default state - expect(await page.screenshot()).toMatchSnapshot(`DataTable.${story.title}.${theme}.png`) + expect( + await page.screenshot({ + mask: await page + .locator('td', { + has: page.locator('relative-time'), + }) + .all(), + }), + ).toMatchSnapshot(`DataTable.${story.title}.${theme}.png`) }) test('axe @aat', async ({page}) => { From 37aaa52a1b0e7b19f42596978b624b26c3f9cb2b Mon Sep 17 00:00:00 2001 From: Tyler Jones Date: Tue, 7 Jan 2025 17:14:32 -0500 Subject: [PATCH 4/4] update package-lock --- package-lock.json | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/package-lock.json b/package-lock.json index 7034f4fa55e..a5c10577eb8 100644 --- a/package-lock.json +++ b/package-lock.json @@ -6040,7 +6040,7 @@ } }, "node_modules/@primer/behaviors": { - "version": "1.7.2", + "version": "0.0.0-20250107215005", "dev": true, "license": "MIT" }, @@ -30825,12 +30825,6 @@ } } }, - "packages/react/node_modules/@primer/behaviors": { - "version": "0.0.0-20250107215005", - "resolved": "https://registry.npmjs.org/@primer/behaviors/-/behaviors-0.0.0-20250107215005.tgz", - "integrity": "sha512-LF5qqziUObrMI55qt6ZTCWW7ysyDqMcyZIYZ63Fdi/wmcJYtsyy5t3bO1mVB1OGBtvTRBmKzJ5pofs4NUUAQPQ==", - "license": "MIT" - }, "packages/react/node_modules/@primer/primitives": { "version": "10.2.0", "license": "MIT"