Rename color blind themes #254
Conversation
🦋 Changeset detectedLatest commit: 14c471f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primitives/FmqYUtJQMjM2uyv3LyGyBfUYX56a |
Variables changedNo variables changed |
.changeset/green-apples-hang.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@primer/primitives": patch | |||
There was a problem hiding this comment.
Isn't this a breaking change?
There was a problem hiding this comment.
Isn't this a breaking change?
Yeah. I guess the question comes up: When should this PR be merged? Should we hold off from merging major changes that are not that urgent? Or is it ok to do major releases quite frequently?
In Primer CSS we have that "next" thing setup so that changesets keep major changes on a separate branch.
for now I'm going to setup the next_major branch here also and we can hold off this change. I don't mind more frequent breaking changes, but I'd like to roll up any so we don't end up with multiple major changes when we don't have to. |
* Creating next_major branch for major releases * Rename color blind themes (#254) * Rename protanopia themes to colorblind * Rename protanopia themes to colorblind * Create green-apples-hang.md * Update green-apples-hang.md * Delete pre.json
* Creating next_major branch for major releases * Rename color blind themes (#254) * Rename protanopia themes to colorblind * Rename protanopia themes to colorblind * Create green-apples-hang.md * Update green-apples-hang.md * Delete pre.json * Add pre.json * Prepare for new gloss buttons with color mode support (#265) * Clean up unused vars * Clean up unused utilities * Clean up light colors * Prep for new color mode supported gloss buttons * Create swift-berries-learn.md Co-authored-by: Jon Rohan <[email protected]> * This changeset was already shipped * Delete pre.json Co-authored-by: Jon Rohan <[email protected]> Co-authored-by: Tobias Ahlin <[email protected]>
This PR renames the protanopia themes to
colorblind