Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .details-reset #371

Merged
merged 1 commit into from
Nov 9, 2017
Merged

Add .details-reset #371

merged 1 commit into from
Nov 9, 2017

Conversation

muan
Copy link
Contributor

@muan muan commented Oct 16, 2017

A follow up for #346.

@shawnbot has recommend that we bring .details-reset out into Primer soon rather than later. I have 2 PRs in github/github needing this class as well.

I put .details-reset in buttons since it's resetting <summary> and <summary> is like a button.

The summary element should be mapped to a disclosure triangle role in accessibility APIs that have such a role. ... In accessibility APIs that do not have such a fine grained role, the summary element should be mapped to a button role.

Feel free to let me know if there is a better place for them. :)

/cc @primer/ds-core

Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, thank @muan! I think we should move the class into a new module eventually, but this makes sense to me as a first step.

@jonrohan jonrohan added the v10 label Oct 27, 2017
@broccolini broccolini changed the base branch from dev to release-10.0.0 November 8, 2017 02:00
@broccolini
Copy link
Member

Merging this into v10, we'll need to remove the dupe code in the /stylesheets/components directory in https://github.com/github/github/pull/80630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants