Use a gray background when hovering SelectMenu items #998
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up for https://github.com/github/github/pull/130408 and moves the changes "downstream".
Here the biggest visual change: Replace the blue background with gray:
Motivation
The main motivation behind the change to use a gray background is to avoid clashing of colors. On dotcom there are cases where SelectMenu items can contain colored icons or color swatches. Using a light gray background makes sure those colors stand out enough.
Note: Dropdown menus are unchanged and keep the blue background.
Concerns