Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a gray background when hovering SelectMenu items #998

Merged
merged 3 commits into from
Dec 17, 2019

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Dec 16, 2019

This is a follow-up for https://github.com/github/github/pull/130408 and moves the changes "downstream".

  • Fix hover of selected tabs
  • Use gray background when an item gets hovered/focused
  • Split filter and footer in the docs (bonus)

Here the biggest visual change: Replace the blue background with gray:

Before After
image image

Motivation

The main motivation behind the change to use a gray background is to avoid clashing of colors. On dotcom there are cases where SelectMenu items can contain colored icons or color swatches. Using a light gray background makes sure those colors stand out enough.

Screen Shot 2019-12-11 at 11 54 10 AM

Note: Dropdown menus are unchanged and keep the blue background.

Concerns

  • GitHub's iconic "blue on hover" is lost.
  • The hover effect with gray is also more subtle and maybe harder to see.

@vercel
Copy link

vercel bot commented Dec 16, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-css/rmmc9bsho
🌍 Preview: https://primer-css-git-select-menu-gray.primer.now.sh

Copy link
Contributor

@emilybrick emilybrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm 🙌

@simurai simurai changed the base branch from master to release-14.1.0 December 17, 2019 00:28
@simurai simurai merged commit f2289ff into release-14.1.0 Dec 17, 2019
@simurai simurai deleted the select-menu-gray branch December 17, 2019 00:28
@simurai simurai mentioned this pull request Dec 17, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants