Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new yellow utilities and variables #737

Merged
merged 7 commits into from
May 14, 2019
Merged

Add new yellow utilities and variables #737

merged 7 commits into from
May 14, 2019

Conversation

broccolini
Copy link
Member

@broccolini broccolini commented Mar 19, 2019

Started this pr because I was testing something, @simurai or @shawnbot could you take this over and ship? Not urgent but fairly low effort.

Ref https://github.com/github/design-systems/issues/596

The bg-yellow-dark utility and variable to replace bg-pending, and text-yellow utility and variable to replace text-pending. These are using in a fair few places in dotcom so will need to update there before deprecating.

To do:

  • update docs
  • update stories (if we need to?)
  • add deprecation warning so can deprecate in a major release

@simurai
Copy link
Contributor

simurai commented Mar 20, 2019

Docs update:

Utility Screenshot
.text-yellow image
.bg-yellow-dark image
.bg-yellow-dark image

@simurai
Copy link
Contributor

simurai commented Mar 20, 2019

Ok, I think this is ready for the next minor (12.3.0) release.

@simurai simurai changed the base branch from release-12.2.1 to master March 20, 2019 09:04
@simurai simurai changed the title [WIP] Add new yellow utilities and variables Add new yellow utilities and variables Mar 22, 2019
@shawnbot shawnbot mentioned this pull request Apr 29, 2019
13 tasks
src/utilities/colors.scss Outdated Show resolved Hide resolved
Co-Authored-By: simurai <[email protected]>
@simurai simurai requested a review from shawnbot May 1, 2019 00:53
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@simurai simurai changed the base branch from master to release-12.4.0 May 14, 2019 23:43
@simurai simurai merged commit 534ff62 into release-12.4.0 May 14, 2019
@simurai simurai deleted the brocs_test branch May 14, 2019 23:45
@shawnbot shawnbot mentioned this pull request May 14, 2019
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants