Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update legacy shadows #2590

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Update legacy shadows #2590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dd5452
just change them all
langermank Mar 19, 2024
c69ac11
Create angry-cycles-smell.md
langermank Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/angry-cycles-smell.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/css": patch
---

Use legacy shadow for all floating shadows
2 changes: 1 addition & 1 deletion src/select-menu/select-menu.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ $SelectMenu-max-height: 480px !default;
font-size: $font-size-small;
border-color: var(--borderColor-default, var(--color-border-default));
border-radius: $border-radius;
box-shadow: var(--shadow-floating-small, var(--color-overlay-shadow));
box-shadow: var(--shadow-floating-legacy, var(--color-overlay-shadow));
animation-name: SelectMenu-modal-animation--sm;
}
}
Expand Down
10 changes: 5 additions & 5 deletions src/toasts/toasts.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
color: var(--fgColor-default, var(--color-fg-default));
background-color: var(--bgColor-default, var(--color-canvas-default));
border-radius: $border-radius;
box-shadow: inset 0 0 0 1px var(--borderColor-default, var(--color-border-default)), var(--shadow-floating-small, var(--color-overlay-shadow));
box-shadow: inset 0 0 0 1px var(--borderColor-default, var(--color-border-default)), var(--shadow-floating-legacy, var(--color-overlay-shadow));

@include breakpoint(sm) {
width: max-content;
Expand Down Expand Up @@ -53,7 +53,7 @@

.Toast--loading {
color: var(--fgColor-default, var(--color-fg-default));
box-shadow: inset 0 0 0 1px var(--borderColor-default, var(--color-border-default)), var(--shadow-floating-small, var(--color-overlay-shadow));
box-shadow: inset 0 0 0 1px var(--borderColor-default, var(--color-border-default)), var(--shadow-floating-legacy, var(--color-overlay-shadow));

.Toast-icon {
background-color: var(--bgColor-neutral-emphasis, var(--color-neutral-emphasis));
Expand All @@ -62,7 +62,7 @@

.Toast--error {
color: var(--fgColor-default, var(--color-fg-default));
box-shadow: inset 0 0 0 1px var(--borderColor-default, var(--color-border-default)), var(--shadow-floating-small, var(--color-overlay-shadow));
box-shadow: inset 0 0 0 1px var(--borderColor-default, var(--color-border-default)), var(--shadow-floating-legacy, var(--color-overlay-shadow));

.Toast-icon {
background-color: var(--bgColor-danger-emphasis, var(--color-danger-emphasis));
Expand All @@ -71,7 +71,7 @@

.Toast--warning {
color: var(--fgColor-default, var(--color-fg-default));
box-shadow: inset 0 0 0 1px var(--borderColor-default, var(--color-border-default)), var(--shadow-floating-small, var(--color-overlay-shadow));
box-shadow: inset 0 0 0 1px var(--borderColor-default, var(--color-border-default)), var(--shadow-floating-legacy, var(--color-overlay-shadow));

.Toast-icon {
background-color: var(--bgColor-attention-emphasis, var(--color-attention-emphasis));
Expand All @@ -80,7 +80,7 @@

.Toast--success {
color: var(--fgColor-default, var(--color-fg-default));
box-shadow: inset 0 0 0 1px var(--borderColor-default, var(--color-border-default)), var(--shadow-floating-small, var(--color-overlay-shadow));
box-shadow: inset 0 0 0 1px var(--borderColor-default, var(--color-border-default)), var(--shadow-floating-legacy, var(--color-overlay-shadow));

.Toast-icon {
background-color: var(--bgColor-success-emphasis, var(--color-success-emphasis));
Expand Down
Loading