-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ::selection
to root color vars
#2437
Conversation
🦋 Changeset detectedLatest commit: cea2c16 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@langermank This PR will need reverting because the introduction of @include color-mode("light") {
p {
color: green
}
} gets compiled into :root p,
::selection p {
color: green
} which it seems is discarded. Here's a minimal repro to demonstrate that the selector is discarded: https://codepen.io/keithamus/pen/mdQrGMo Refs https://github.com/github/issues/issues/6741, https://github.com/orgs/community/discussions/58723#discussioncomment-6250327 |
This reverts commit 616c893.
Fixes: https://github.com/github/github/issues/264779
What are you trying to accomplish?
We're getting several bug reports in Chrome related to color vars and
::selection
due to a Chromium experiment.What approach did you choose and why?
Based on this article, maybe adding
::selection
will fix the problem?What should reviewers focus on?
Will this break the world?
Can these changes ship as is?