Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment box upload focus border-radius #2049

Merged
merged 7 commits into from
Apr 28, 2022
Merged

Comment box upload focus border-radius #2049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c07304c
missing border-radius
langermank Apr 28, 2022
7dc855a
Create beige-horses-fetch.md
langermank Apr 28, 2022
19ec945
lint
langermank Apr 28, 2022
7e2c28d
Merge branch 'upload-gix' of https://github.com/primer/css into uploa…
langermank Apr 28, 2022
1848006
Merge branch 'next_major' into upload-gix
langermank Apr 28, 2022
f5d04da
you would think I would know these by now
langermank Apr 28, 2022
dbebf72
Merge branch 'upload-gix' of https://github.com/primer/css into uploa…
langermank Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/beige-horses-fetch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/css": major
---

Comment box upload focus border-radius
6 changes: 5 additions & 1 deletion src/forms/form-validation.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,11 @@ dl.form-group > dd, // TODO: Deprecate
}

&.focused {
@include focusBoxShadowInset(2px, var(--color-accent-fg));
border-color: var(--color-accent-fg);
border-radius: $border-radius;
outline: none;
// stylelint-disable-next-line primer/box-shadow
box-shadow: 0 0 0 2px var(--color-accent-fg);

.form-control {
border-color: transparent;
Expand Down