Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment box upload focus border-radius #2049

Merged
merged 7 commits into from
Apr 28, 2022
Merged

Comment box upload focus border-radius #2049

merged 7 commits into from
Apr 28, 2022

Conversation

langermank
Copy link
Contributor

Missing border-radius from feature flag

@langermank langermank requested a review from a team as a code owner April 28, 2022 22:01
@changeset-bot
Copy link

changeset-bot bot commented Apr 28, 2022

🦋 Changeset detected

Latest commit: dbebf72

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@langermank langermank merged commit f4dba96 into next_major Apr 28, 2022
@langermank langermank deleted the upload-gix branch April 28, 2022 22:17
@primer-css primer-css mentioned this pull request Apr 28, 2022
jonrohan added a commit that referenced this pull request Apr 29, 2022
* Adding pre.json

* Delete pre.json

* Marketing: Remove unused pullquote selector (#1767)

* Remove unused pullquote style

* Create good-fireants-collect.md

* next_major protection

* On push

* Exit 1

* Update instructions

* Underline nav focus state (#1821)

* add pseudo selectors

* adjustments

* add stories, cleanup

* update mixin

* fix mixin

* lint

* add back overflow styles

* adjust focus for better overflow state, scrollsnap

* post test adjustments, move hacks to primer css

* Stylelint auto-fixes

* hover state desktop only

* document data-content hack

* Create nice-days-jog.md

* Use counter-border for LHC (#1792)

* Use counter-border for LHC

* Create orange-ties-sin.md

* Remove fallback

* Update nice-days-jog.md

Co-authored-by: langermank <[email protected]>
Co-authored-by: Actions Auto Build <[email protected]>
Co-authored-by: simurai <[email protected]>

* Global focus styles (#1744)

* setup base focus styles

* add feature stories

* add stories for focusable things, delete outline:0

* switch back to box-shadow

* support class

* stylelint

* fix theme viewer

* switch back to outline, address feedback

* lint

* temp stashing stories here

* Create giant-bees-talk.md

* I think we got it!

* address input directly

* checkbox/radio outline offset

* lint

* change actionlist to just use focus

* merge

* Update giant-bees-talk.md

* address marketing styles

* tabnav focus fix

* reach all buttons

* attempt windows hc selector

* Stylelint auto-fixes

* fixes

* add focus style testing page

* Stylelint auto-fixes

* add href for testing

* remove position relative to fix chrome bug

* fix details scenario

* add offset to WHC

* maintain offset specificity in whc

* inset tabnav focus

* switch offset to inset

* fix actionlist focus

* lint

* better scoping, handle forms for safari

* moving specific styles from dotcom

* address autocomplete

* cleanup

* cleanup

* selected focus states

* adjust marketing focus

* use offset instead for marketing

* Stylelint auto-fixes

* fix merge

Co-authored-by: Jon Rohan <[email protected]>
Co-authored-by: Actions Auto Build <[email protected]>

* Upgrading to stylelint-config-12.4.0 (#2041)

* Upgrading to stylelint-config-12.4.0

* Create tame-clouds-shop.md

* Global focus style CSS from feature flag (#2046)

* extra CSS found from cleaning up feat flag

* lint

* Create young-trainers-yell.md

* fix mixin

Co-authored-by: Jon Rohan <[email protected]>

* UnderlineNav bug fix (#2047)

* fix selector (bad merge?)

* Create ninety-bobcats-do.md

* lint

* Comment box upload focus border-radius (#2049)

* missing border-radius

* Create beige-horses-fetch.md

* lint

* you would think I would know these by now

* Fix headings with an anchor in a summary (#2048)

* Fix headings with an anchor in a summary

* Create hip-readers-press.md

* Lint

* Version Packages

Co-authored-by: Jon Rohan <[email protected]>
Co-authored-by: Tobias Ahlin <[email protected]>
Co-authored-by: langermank <[email protected]>
Co-authored-by: Actions Auto Build <[email protected]>
Co-authored-by: simurai <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant