Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent content to increase main's size #1486

Merged
merged 3 commits into from
Jul 2, 2021
Merged

Conversation

manuelpuyol
Copy link
Contributor

Based on https://css-tricks.com/preventing-a-grid-blowout/

If main's content was large enough, it would cause main to grow more than it should and push sidebar to the side, causing an horizontal scroll on pages.

Before After
image image

@changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2021

🦋 Changeset detected

Latest commit: 0e0ca95

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@manuelpuyol manuelpuyol enabled auto-merge (squash) July 2, 2021 14:34
@manuelpuyol manuelpuyol merged commit f52d40c into main Jul 2, 2021
@manuelpuyol manuelpuyol deleted the fix-layout-grid-blowout branch July 2, 2021 14:35
@primer-css primer-css mentioned this pull request Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants