-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert markdown page to one big example #1065
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-css/jic7tls0s |
The difference is that before we were testing markdown styling by just writing the markdown "as if it was the content". And therefore Primer Components did the styling. This PR convertes the markdown to HTML and then wrapps it in a "live example" by adding these 3 backticks Before:
After
Now since it's a "live example", Primer CSS and the
This is just the normal border that is shown around "live examples". It might look a bit odd since the markdown example is huge and you need to scroll a long time to reach the "code". Smaller ones look like this:
Yeah, the TOC wasn't really useful since the headers are only there to test how headers render, but not to navigate between different sections like on normal pages. |
Co-Authored-By: Emily Brick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This is a left-over from #917. It shows the markdown content (that got manually converted to HTML) as a live example.
.markdown-body
styling instead of Doctocat (Primer Components).