Alternative formatting CSS code rgba (Jekyll sass doesn't like spaces)

[svrooij]

The following code is incorrect:

The rgba function requires 4 arguments, so rgba(255 255 255 / 0.15) should be rgba(255, 255, 255, 0.15).

At least that fixed my Jekyll error:

/usr/gem/gems/jekyll-sass-converter-1.5.2/lib/jekyll/converters/scss.rb:123:in `rescue in convert': wrong number of arguments (1 for 4) for `rgba' on line 16 (Jekyll::Converters::Scss::SyntaxError)

css/src/marketing/buttons/button.scss

Line 16 in c65be7f

background: linear-gradient(180deg, rgba(255 255 255 / 0.15) 0%, rgba(255 255 255 / 0) 100%), var(--color-mktg-btn-bg) !important;

and

css/src/marketing/buttons/button.scss

Line 32 in c65be7f

background: linear-gradient(180deg, rgba(255 255 255 / 0.15) 0%, rgba(255 255 255 / 0) 100%) !important;

[simurai]

@svrooij Thanks for the report, should be changed in #1781.

[tobiasahlin]

FWIW this is just Jekyll acting up, this is the functional color syntax: https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/rgba()

[svrooij]

@tobiasahlin Does this mean you're against approving this PR to change the CSS, and actually want them to fix the jekyll sass compiler?

I was using the marketing css in a Github Page. And it screamed error. I created an issue on Jekyll-sass-converter as well, would the above PR be acceptable as a quick fix?

[tobiasahlin]

Not against a fix at all if this error is being thrown on GitHub Pages 🙏 just want to call out that this formatting is not "wrong" from a standards point of view. We can totally fix it locally while encouraging that it's also fixed in the converter (like you just did—thanks for opening that issue @svrooij!)

[svrooij]

just want to call out that this formatting is not "wrong" from a standards point of view.

And that is why I also changed the title of this issue. 😄