Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve footnotes #1627

Closed
simurai opened this issue Sep 30, 2021 · 1 comment
Closed

Improve footnotes #1627

simurai opened this issue Sep 30, 2021 · 1 comment
Labels
Stale Automatically marked as stale.

Comments

@simurai
Copy link
Contributor

simurai commented Sep 30, 2021

Currently the footnotes added in #1616 only have space for 1 digit and start to look odd when there are more:

Screen Shot 2021-09-29 at 09 01 57

Possible fixes

Option A

There is list-style-position: inside; to make the numbers appear inside the <li>, but alignment won't look nice: laurent22/joplin#4715 (comment). And also doesn't look good with multi line text. Maybe there is some other hack?

Option B

  1. Adding enough indentation for at least 2 digits, maybe 3 digits
  2. Add a bit padding on the left of <li>
  3. Then use the blue border only inside of the <li>

We kinda had that in an initial version:

Screen Shot 2021-09-30 at 11 07 03

Option C

Maybe find another way to show that an item has :target. Often a yellow background is used to highlight something.

Option D

Use <table> instead of <ol>. Then the column width automatically adjusts base on the content. But that's a big change and probably a bad idea.

/cc @vdepizzol

@github-actions
Copy link
Contributor

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

@github-actions github-actions bot added the Stale Automatically marked as stale. label Mar 29, 2022
@github-actions github-actions bot closed this as completed Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Automatically marked as stale.
Projects
None yet
Development

No branches or pull requests

1 participant