Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageCompare: ARIA Attributes #6912

Closed
daniel-hitchins opened this issue Dec 2, 2024 · 0 comments
Closed

ImageCompare: ARIA Attributes #6912

daniel-hitchins opened this issue Dec 2, 2024 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@daniel-hitchins
Copy link

Describe the bug

Adding ARIA Attributes Does Not Render in the Final Output

Reproducer

https://stackblitz.com/edit/cklcte?file=src%2FApp.vue

PrimeVue version

4.2.4

Vue version

3.x

Language

ALL

Build / Runtime

Vue CLI App

Browser(s)

Chrome 131.0.6778.86

Steps to reproduce the behavior

Adding either aria-labelledby or aria-label to the ImageCompare component doesn't render either attribute in the final output.

Expected behavior

I would expect that by adding either aria-labelledby or aria-label to the ImageCompare component, they would appear in the final output.

Additionally, the thumb element, with its transparency, will almost always fail the colour contrast test, as the transparency of images can be unpredictable. A better solution would be to allow for a template to add an icon into the thumb, which means we could make the background opaque or nearly opaque. This would provide a clear visual cue on what to do, and we could control the icon colour to ensure a good contrast ratio for accessibility.

@daniel-hitchins daniel-hitchins added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 2, 2024
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 4, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.2.5 milestone Dec 4, 2024
@tugcekucukoglu tugcekucukoglu self-assigned this Dec 10, 2024
@github-project-automation github-project-automation bot moved this to Done in PrimeVue Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
Status: Done
Development

No branches or pull requests

2 participants