Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable: RowExpansion & RowSelection #6904

Closed
Azalen opened this issue Dec 1, 2024 · 3 comments · Fixed by #6920
Closed

DataTable: RowExpansion & RowSelection #6904

Azalen opened this issue Dec 1, 2024 · 3 comments · Fixed by #6920
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Azalen
Copy link

Azalen commented Dec 1, 2024

Describe the bug

When I use an outer DataTable with Row Expansion and an inner DataTable and I want the inner DataTable be use RowSelection (single mode) the Fokus breaks. After this I cannot access the inner DataTable anymore via Keyboard Tabbing.

You can see this issue live in action in here by opening a Row Expansion and then click on the outer DataTables row (the row you just used for expansion)

https://stackblitz.com/edit/lwvsx7?file=src%2FApp.vue

chunk-VT7FWPCL.js?v=073310a7:2351 Uncaught TypeError: Cannot set properties of null (setting 'tabIndex')
    at Proxy.onRowClick2 (primevue_datatable.js?v=5caf848d:12067:28)

Reproducer

https://stackblitz.com/edit/lwvsx7?file=src%2FApp.vue

PrimeVue version

4.2.0

Vue version

3.x

Language

ALL

Build / Runtime

Vite

Browser(s)

Chrome

Steps to reproduce the behavior

opening a Row Expansion and then click on the outer DataTables row (the row you just used for expansion) on some empty space

Expected behavior

Fokus and thus the ability to access the inner DataTable via Keyboard should not break

@Azalen Azalen added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 1, 2024
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Resolution: Help Wanted Issue or pull request requires extra help and feedback and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

Due to PrimeVue team's busy roadmap, this issue is available for anyone to work on. Make sure to reference this issue in your pull request. ✨ Thank you for your contribution! ✨

@KumJungMin
Copy link
Contributor

I submitted a PR to resolve the error message. Are you looking to address the error message, or is your focus more on fixing the tab navigation issue?

@Azalen

@Azalen
Copy link
Author

Azalen commented Dec 4, 2024

Tab Navigation Issue, because functionality breaks meaning after that click I cannot target the inner DataTable with Tab anymore.

@tugcekucukoglu tugcekucukoglu removed the Resolution: Help Wanted Issue or pull request requires extra help and feedback label Dec 5, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.2.5 milestone Dec 5, 2024
@github-project-automation github-project-automation bot moved this to Done in PrimeVue Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants