Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chip component's removable Icon uses aria-hidden #6864

Closed
bonniegrubbs opened this issue Nov 25, 2024 · 0 comments
Closed

Chip component's removable Icon uses aria-hidden #6864

bonniegrubbs opened this issue Nov 25, 2024 · 0 comments
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
4.2.4

Comments

@bonniegrubbs
Copy link

bonniegrubbs commented Nov 25, 2024 •
edited
Loading

Describe the bug

The Chip component is using aria-hidden on the removable Icon which causes a console error when the Chip is removed from the DOM:
image

I believe the issue is caused by this.

Reproducer

https://primevue.org/chip/#image

PrimeVue version

4.2.3

Vue version

4.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

Go to https://primevue.org/chip/#image and remove a chip by using the "X" button/icon.
You should see the error in the console output.

Expected behavior

Closing a chip should not cause a console error.
@bonniegrubbs bonniegrubbs added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 25, 2024
@tugcekucukoglu tugcekucukoglu self-assigned this Nov 26, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.2.4 milestone Nov 26, 2024
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 26, 2024
@tugcekucukoglu tugcekucukoglu changed the title Component Name: Chip component's removable Icon uses aria-hidden Chip component's removable Icon uses aria-hidden Nov 26, 2024
@github-project-automation github-project-automation bot moved this to Done in PrimeVue Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
PrimeVue
Status: Done
Milestone
4.2.4
Development

No branches or pull requests
2 participants
@bonniegrubbs @tugcekucukoglu