Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select: Cannot read properties of null (reading '$el') - filter and auto-filter-focus error #6793

Closed
Tamas-hi opened this issue Nov 17, 2024 · 6 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Tamas-hi
Copy link
Contributor

Describe the bug

Following up on #6539 , this problem is still occurs when you click out of the open dropdown.
Previous fix was not sufficient.

Reproducer

https://stackblitz.com/edit/lhc6ls?file=src%2FApp.vue

PrimeVue version

4.2.2

Vue version

4.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

Brave

Steps to reproduce the behavior

  1. Open the reproducer link.
  2. Open console
  3. Click on the dropdown and then click out of it.
  4. See the error

Expected behavior

No error message

@Tamas-hi Tamas-hi added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 17, 2024
@sivareddyuppathi
Copy link
Contributor

Fix for the above issue.

PR: #6787

@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 22, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.2.3 milestone Nov 22, 2024
@tugcekucukoglu tugcekucukoglu self-assigned this Nov 22, 2024
@SamGeodynamics
Copy link

SamGeodynamics commented Nov 26, 2024

updated everything to 4.2.3 but it's still giving the same error, there seems to be a mixup with the PR's, the actual fix has been closed because there were 2 small fixes pushed, but no other PR's have been suggested, the problem was marked as fixed but it wasn't.

I have patch-package'd it for now...

@parkersprouse
Copy link

Hi @tugcekucukoglu, I just want to make sure the state of this issue receives the necessary attention to help clear up any confusion and prevent it from slipping through the cracks.

Like @SamGeodynamics mentioned, this issue was marked as completed, but the initial PR (#6787) that attempted to fix it was closed without being merged in due to attempting to resolve multiple issues in a single PR.

So then the author of the original PR split out the work for the Select fix into a new PR (#6839) as requested, but the PR was closed under the false assumption that the fix for the Select issue had already been merged in when it hadn't.

And now when new issues (#6804) get opened mentioning the same problem, they get closed as duplicates.

I'm sure this is nothing more than a misunderstanding and/or an oversight from jumping between the various issues and PRs, but as for where things currently stand, a fix for the Select filtering focus issue has not been merged in or made available in any released version of the library, requiring local patching for it to be included.

@ellisj98
Copy link

ellisj98 commented Dec 3, 2024

This is also an issue that is affecting my code in production.

@Tamas-hi
Copy link
Contributor Author

Should we open another issue? I think this is still a problem.

@nexgen-ui
Copy link

Yes, it is still an issue. I logged the #6804 issue and am still waiting for a fix. This bug should have a higher priority in my view as it happens on every single dropdown list with auto focus filter property enabled. I had to roll my code back to version 4.0.7 because of this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

7 participants