Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable sort & selection stops working on Vue 3.0.1 #582

Closed
LadislavBohm opened this issue Oct 16, 2020 · 11 comments
Closed

DataTable sort & selection stops working on Vue 3.0.1 #582

LadislavBohm opened this issue Oct 16, 2020 · 11 comments

Comments

@LadislavBohm
Copy link

With no other changes after updating to Vue 3.0.1 DataTable sorting and selection stopped working. When I click a row nothing gets selected. When I click a header nothing happens as well.

@dheimoz
Copy link

dheimoz commented Oct 18, 2020

Thanks for the heads-up LadislavBohm. If you return to ver 3.0.0 does everything work as expected? I saw there were about 9 vulnerabilities related to outdated packages. I created a pull request with the updated packaged. Will give it a try the DataTable Sort with those changes applied and Vue 3.0.1 and comment.

@dheimoz
Copy link

dheimoz commented Oct 19, 2020

Hello @cagataycivici I have confirmed the suspicious of LadislavBohm. Vue 3.0.1 breaks VuePrime 3. Not only DataTable sort but also Tree and TreeView.

I believe guys there are a lot of refactor work to be done with Vue 3.0.1

Will try to narrow the problem. Let you know if I found something useful.

Once again thanks for the great work.

@cagataycivici
Copy link
Member

3.0.1 spring begins tomorrow, let me work on this, I hope it is nothing serious.

@cagataycivici cagataycivici added this to the 3.0.1 milestone Oct 20, 2020
@cagataycivici cagataycivici self-assigned this Oct 20, 2020
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Oct 20, 2020
@dheimoz
Copy link

dheimoz commented Oct 20, 2020

Thanks for jumping in @cagataycivici . PrimeVue is promising.

@cagataycivici
Copy link
Member

Could you please test with Vue 3.0.2 as well?

https://github.com/vuejs/vue-next/releases/tag/v3.0.2

@LadislavBohm
Copy link
Author

Warnings from 3.0.1+ (even 3.0.2 that I tested just now)
image

Warnings from 3.0.0
image

It looks like update:selection event is not being emitted and v-model:selection is thus not working.

@cagataycivici
Copy link
Member

Warnings are easy to fix, we'll add the emits: prop, if this is related to it, then should be an easy fix, let me work on it today and get back to you.

@cagataycivici
Copy link
Member

I'm not able to replicate the sort select issue on table, tried both on 3.0.1 and 3.0.2, seems to work. Can you provide a code sandbox that replicates it? I'll fix the emits warnings now about 549.

@LadislavBohm
Copy link
Author

Ok I think I found the issue as I was not able to reproduce this on any new project I just created. I deleted node_modules and package-lock.json and now it's working fine on Vue 3.0.2 and all warning are gone. Sorry about that.

It's most likely because I bootstrapped the project using vue-cli but some older version when Vue 3 was still in RC phase. Now when you delete package-lock.json it gets a new one and it works. Probably fixes #549 as well.

@LadislavBohm
Copy link
Author

However this issue still persists even with my repo that is able to reproduce it #536

@cagataycivici
Copy link
Member

Glad to hear, 549 need changes from our side which is done.

@cagataycivici cagataycivici removed this from the 3.0.1 milestone Oct 22, 2020
@cagataycivici cagataycivici removed the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Oct 22, 2020
@cagataycivici cagataycivici removed their assignment Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants