-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PrimeVue with Vite 5: Missing common CSS Styles #5249
Comments
Interesting! We'll check and get back to you. I set a milestone for it. |
I wanted to create a new issue, but it looks like this issue is related/similar: Minimum source to reproduce the issue: |
Found the issue! |
@marknn3 nice on finding that. Ye, that is definitly a breaking change ! My fix for this was exactly taking one of the themes. Problem here was that it changed some styles which I had to change it manually. There should be a "default" theme like the one that we allready had. |
I too am surprised that this change wasn't flagged as a major release. It's going to take a couple of additional days dev time to upgrade our web platform to utilise the latest PrimeVue release (3.48.x). |
I agree - this doesn't have anything to do with upgrade Vite from 4 to 5. |
For more information please check #5214 |
Describe the bug
Im using the latest PrimeVue Version 3.48.0 and I just upgraded Vite from 4 to 5. After migration the common styles of each primevue components are not loaded anymore. I saw that they have some breaking changes: See https://vitejs.dev/guide/migration.html.
E.g. On the screenshot you can see some styles of the multiselect component which are not loaded anymore when I upgrade vite to 5.
Btw. I use Prestige Template and all styles of the template are loaded properly. These are included on the main.ts file.
Has anybody faced the same issue? Is there are workaround to fix this ? Im not even sure if this problem is related to primevue. Since only the upgrade from vite changes the behaviour. But I want to make sure if I have to change the import of the styles. Since Primevue did also some changes on styles. E.g. the primevue.min.css got removed and also they added @layer.
(See #4647 or: #4110)
Maybe that`s useful to know:
I use TS and everything is configured to ESM. We did not import a theme. As I said only the prestige template were used and imported to main.ts and the other styles were coming directly from primevue components.
Reproducer
PrimeVue version
3.48.0
Vue version
3.x
Language
TypeScript
Build / Runtime
Vite
Browser(s)
No response
Steps to reproduce the behavior
Upgrade to vite 5 from 4 and see that the common styles of each primevue components are not loaded anymore.
Expected behavior
Common Styles of each primevue component should loaded
The text was updated successfully, but these errors were encountered: