Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar: 12h time picker changes from 12 am to 12 pm automatically #5108

Closed
dmhendricks opened this issue Jan 18, 2024 · 1 comment
Closed
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@dmhendricks
Copy link

dmhendricks commented Jan 18, 2024

Describe the bug

If the 12-hour time picker contains a time between midnight and 1am, it will automatically switch to pm if a new date is selected. Previously mentioned in #4449.

This has caused a number of scheduling incidents with users when they pull up a document, change the date, and don't notice that the am subtly and automatically changes to pm.

Reproducer

(see steps to reproduce below)

PrimeVue version

3.46.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

You can reproduce it on the current v3.46.0 documentation page demo:

  1. Go here: https://primevue.org/calendar/
  2. Select a date and time. Make the time 12:xx AM. Example:
Screenshot 2023-10-11 at 10 56 36 AM
  1. Click off of field to remove focus (you can click anywhere else on the page)
  2. Click on the field again and select any date (don't touch the time, just change the date). When you do that, the "am" will automatically change to "pm" even though the time wasn't changed/touched:
Screenshot 2023-10-11 at 10 58 51 AM

Expected behavior

If you click the field to change the date, the time that was previously selected should be preserved rather than automatically switching from am to pm.

@dmhendricks dmhendricks added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 18, 2024
@mertsincan
Copy link
Member

Thanks a lot for your report! I set a milestone and we'll fix it before the milestone is released. Best Regards,

@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 18, 2024
@mertsincan mertsincan added this to the 3.48.0 milestone Jan 18, 2024
@tugcekucukoglu tugcekucukoglu self-assigned this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants