Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement TabView with Templating #51

Closed
lochstar opened this issue Sep 3, 2019 · 1 comment
Closed

Reimplement TabView with Templating #51

lochstar opened this issue Sep 3, 2019 · 1 comment
Assignees
@cagataycivici
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
1.0.0-beta.9

Comments

@lochstar
Copy link
Contributor

lochstar commented Sep 3, 2019

I get an error when trying to import the TabView component:

You may need an additional loader to handle the result of these loaders.

This is because of the use of JSX for this component, commit is here: b3036ec

Is it a requirement we must include https://github.com/vuejs/jsx in order to build this project? Can we refactor the JSX back to Vue template format? It's not clear to me why it had to be changed.
@cagataycivici
Copy link
Member

I think we can redo the tabview with templating, I'll check this.

@cagataycivici cagataycivici changed the title Unable to import TabView Reimplement TabView with Templating Oct 1, 2019
@cagataycivici cagataycivici self-assigned this Oct 1, 2019
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Oct 1, 2019
@cagataycivici cagataycivici added this to the 1.0.0-beta.9 milestone Oct 1, 2019
@cagataycivici cagataycivici mentioned this issue Oct 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
1.0.0-beta.9
Development

No branches or pull requests
2 participants
@cagataycivici @lochstar