Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CascadeSelect: Submenu(list) items go off screen and does not allow vertical scroll bar #5007

Closed
baaskoen opened this issue Dec 28, 2023 · 3 comments

Comments

@baaskoen
Copy link

Describe the bug

As in the reproducer link (https://stackblitz.com/edit/4fw4mp-y1ukj2?file=src%2FApp.vue), if you open the submenu "Australia", you cannot scroll down with your keyboard buttons. By default the list also has no max-height, meaning it will just create a long unfriendly list.

In discord someone helped me with a temporary hotfix which can be seen here:
https://stackblitz.com/edit/4fw4mp-1ceoxn?file=src%2FApp.vue

Reproducer

https://stackblitz.com/edit/4fw4mp-y1ukj2?file=src%2FApp.vue

PrimeVue version

3.45.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

See the attached stackblitz.

Expected behavior

By default, submenu's and sublists (see also TieredMenu) should have a max height, and should be scrollable with keyboard buttons.

@baaskoen baaskoen added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 28, 2023
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 5, 2024
@melloware
Copy link
Member

We have an open PrimeReact PR to fix this if you want to port it to PrimeVue

primefaces/primereact#5681

@mertsincan
Copy link
Member

Thanks a lot for your report! I set a milestone for it. We'll review it before the milestone is released.

@mertsincan mertsincan added this to the 3.50.0 milestone Jan 29, 2024
@tugcekucukoglu tugcekucukoglu modified the milestones: 3.50.0, 3.52.0 Mar 15, 2024
@tugcekucukoglu tugcekucukoglu modified the milestones: 3.52.0, 4.x Apr 24, 2024
@tugcekucukoglu
Copy link
Member

Fixed with version 4.

@tugcekucukoglu tugcekucukoglu removed this from the 4.x milestone Nov 26, 2024
@tugcekucukoglu tugcekucukoglu removed the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants