Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.41 version bug: Toast & Slider style #4885

Closed
xushnudbek20 opened this issue Nov 28, 2023 · 5 comments
Closed

3.41 version bug: Toast & Slider style #4885

xushnudbek20 opened this issue Nov 28, 2023 · 5 comments

Comments

@xushnudbek20
Copy link

Describe the bug

When I update primevue from 3.32.1 to 3.41.1. I seen that style bugs.

image
Before:
image

After:
image

Reproducer

PrimeVue 3 Issue Template

PrimeVue version

3.41.1

Vue version

3.x

Language

TypeScript

Build / Runtime

Nuxt

Browser(s)

Chrome 119

Steps to reproduce the behavior

No response

Expected behavior

No response

@xushnudbek20 xushnudbek20 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 28, 2023
@Xyorqin
Copy link

Xyorqin commented Nov 28, 2023

Are changed any styles?

@xushnudbek20
Copy link
Author

Are changed any styles?

No, I just updated primevue version

@xushnudbek20 xushnudbek20 changed the title 3.41 version bug 3.41 version bug: Toast & Slider style Nov 28, 2023
@FlipWarthog
Copy link
Contributor

@layer was added in 3.35.0 (#4504); could be you have custom styles that previously were not overriding PrimeVue styles but now are.

@tugcekucukoglu
Copy link
Member

@layer was added in 3.35.0 (#4504); could be you have custom styles that previously were not overriding PrimeVue styles but now are.

Thank you @FlipWarthog . It solves the problem.

@tugcekucukoglu tugcekucukoglu removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 29, 2023
@slumtrimpet
Copy link

slumtrimpet commented Nov 30, 2023

@tugcekucukoglu

I don't understand how the @FlipWarthog comment solves the problem. So if for example we had generic CSS of the following in our project root:

* {
  margin: 0;
  padding: 0;
}

That now overrides all padding and margin style in primevue while it previously did not. That doesn't really seem acceptable. How do you suggest we resolve this?

(this also ties into #4688 and #4504 and I'd assume a lot of headaches since this breaking change was made)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants