Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password: add "@change" event #4219

Closed
darkvertex opened this issue Jul 28, 2023 · 2 comments
Closed

Password: add "@change" event #4219

darkvertex opened this issue Jul 28, 2023 · 2 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@darkvertex
Copy link

Describe the bug

The <Password> component does not react to @change events.

(#2610 hints that apparently it once used to.)

Reproducer

https://codesandbox.io/s/muddy-frost-9rjfdy?file=/src/App.vue

PrimeVue version

3.31.0

Vue version

3.x

Language

ALL

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

See my Stackblitz link for an example.

Basically, "@change" events do nothing on a <Password> component tag.

(Looks like a potential regression given that #2610 claims it was fixed in Primevue 2.x)

Expected behavior

I expect the event to trigger when clicking away or when pressing enter inside the element.

@darkvertex darkvertex added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 28, 2023
@AfzalSabbir
Copy link

AfzalSabbir commented Jul 29, 2023

@darkvertex no you can't use @change. You know what, I think you can use one of

  • @input
  • @focus
  • @blur
  • @keyup

Specifically you can use @blur

@tugcekucukoglu
Copy link
Member

tugcekucukoglu commented Aug 2, 2023

#2610 is about the lack of input emit in PrimeVue 2. But in Vue 3 there is @update:modelValue can be used for two-way data binding. For more information: https://vuejs.org/guide/components/v-model.html#component-v-model

In any way, I will also add change emit.

@tugcekucukoglu tugcekucukoglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 2, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.31.1 milestone Aug 2, 2023
@tugcekucukoglu tugcekucukoglu self-assigned this Aug 2, 2023
@tugcekucukoglu tugcekucukoglu changed the title Password: not reacting to "@change" events Password: add "@change" event Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

3 participants