Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar: Extraneous non-props attributes warnings #3524

Closed
dmhendricks opened this issue Jan 11, 2023 · 0 comments · Fixed by #3527
Closed

Sidebar: Extraneous non-props attributes warnings #3524

dmhendricks opened this issue Jan 11, 2023 · 0 comments · Fixed by #3527
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@dmhendricks
Copy link

Describe the bug

After upgrading from 3.20.0 to 3.22.0, I'm getting the following warnings when using the Sidebar component:

Extraneous non-props attributes (class) were passed to component but could not be automatically inherited because component renders fragment or text root nodes.

Sidebar console warning

If I remove the class attribute from the following, the warnings go away:

<Sidebar v-model:visible="visibleLeft" class="p-sidebar-md"></Sidebar>

Reproducer

 

PrimeVue version

3.22.0

Vue version

3.x

Language

ES6

Build / Runtime

Vue CLI App

Browser(s)

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.0.0 Safari/537.36

Steps to reproduce the behavior

  1. Add a Sidebar component with a class parameter
  2. Reload page
<Sidebar v-model:visible="visibleLeft" class="p-sidebar-md"></Sidebar>

Expected behavior

In previous versions, these warnings were not present.

@dmhendricks dmhendricks added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 11, 2023
@bahadirsofuoglu bahadirsofuoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 12, 2023
@bahadirsofuoglu bahadirsofuoglu added this to the 3.23.0 milestone Jan 12, 2023
@bahadirsofuoglu bahadirsofuoglu self-assigned this Jan 12, 2023
@tugcekucukoglu tugcekucukoglu modified the milestones: 3.23.0, 3.22.1 Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants