Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button: Bring the loading prop from primevue3 to primevue2 #2655

Closed
tforget opened this issue Jun 9, 2022 · 1 comment
Closed

Button: Bring the loading prop from primevue3 to primevue2 #2655

tforget opened this issue Jun 9, 2022 · 1 comment
Assignees
@tugcekucukoglu
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add vue2
Milestone
2.10.0

Comments

@tforget
Copy link

tforget commented Jun 9, 2022 •
edited
Loading

Describe the feature you would like to see added

The primevue2 button lacks the primevue3 button prop loading that hides the icon if any and shows a loading spinner unstead.

Most of the work if not all have been done for you here: #2648.

Describe alternatives you have considered

Should the button also be disabled when the loading prop is true?
@tforget tforget added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jun 9, 2022
@tugcekucukoglu tugcekucukoglu added this to the 2.9.3 milestone Jul 1, 2022
@tugcekucukoglu tugcekucukoglu self-assigned this Jul 1, 2022
@mertsincan
Copy link
Member

Fixed in #2648

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add vue2
Projects
None yet
Milestone
2.10.0
Development

No branches or pull requests
3 participants
@mertsincan @tugcekucukoglu @tforget