Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve DataTable ContextMenu Styling #253

Closed
Fanmade opened this issue Apr 1, 2020 · 2 comments
Closed

Improve DataTable ContextMenu Styling #253

Fanmade opened this issue Apr 1, 2020 · 2 comments
Assignees
@cagataycivici
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
1.2.0

Comments

@Fanmade
Copy link

Fanmade commented Apr 1, 2020

When the context menu is closed again, no event is thrown.
So if you right-clicked on a row and click somewhere else to hide the context menu again, the row will stay highlighted until you reload the page.
image
image

It would be great to have an event like "onRowContextMenuClose" to be able to remove the selection of that row again.
@cagataycivici cagataycivici added this to the 1.2.0 milestone Apr 3, 2020
@cagataycivici
Copy link
Member

We've improved it in PrimeNG last week to focus on the row which has its own styling, will the same to PrimeVue for next week's 1.2.0.

@cagataycivici cagataycivici self-assigned this Apr 3, 2020
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Apr 3, 2020
@cagataycivici cagataycivici changed the title Datatable contextmenu row-highlighting does not disappear Improve DataTable ContextMenu Styling Apr 7, 2020
@cagataycivici
Copy link
Member

Also please add new "contextMenu" prop so that the rows can become focusable in 1.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
2 participants
@cagataycivici @Fanmade