Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sub-items in PanelMenu does not receive the router-link-active class #2528

Closed
LorianColtof opened this issue May 9, 2022 · 3 comments
Closed

Sub-items in PanelMenu does not receive the router-link-active class #2528

LorianColtof opened this issue May 9, 2022 · 3 comments
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.13.0

Comments

@LorianColtof
Copy link
Contributor

I'm submitting a ... (check one with "x")

[X] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primevue/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=110

A sub-item in PanelMenu never receives the router-link-active class, which causes it to not be highlighted even though the route matches in a non-exact way.
@LorianColtof LorianColtof changed the title Sub-items in PanelMenu does not receive the router-link-active Sub-items in PanelMenu does not receive the router-link-active class May 9, 2022
@tugcekucukoglu
Copy link
Member

https://github.com/primefaces/primevue/blob/master/src/components/panelmenu/PanelMenuSub.vue#L6

I saw the PR #2529 but I could not replicate the issue. Could you create a codesandbox demo?

@tugcekucukoglu tugcekucukoglu added the Status: Pending Review Issue or pull request is being reviewed by Core Team label May 10, 2022
@LorianColtof
Copy link
Contributor Author

Yes, here you go: https://codesandbox.io/s/reverent-almeida-etrj2z

@LorianColtof
Copy link
Contributor Author

Any update on this?

@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Jun 2, 2022
@tugcekucukoglu tugcekucukoglu added this to the 3.13.0 milestone Jun 2, 2022
@tugcekucukoglu tugcekucukoglu self-assigned this Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.13.0
Development

No branches or pull requests
2 participants
@LorianColtof @tugcekucukoglu