The latest updates on your projects. Learn more about Vercel for Git ↗︎

@melloware Hello! Its done

@KirilCycle i think this may also fix this issue correct? #6417

@KirilCycle i think this may also fix this issue correct? #6417

Exactly!

Let me take a deeper look at this. I like where you are going though.

Let me take a deeper look at this. I like where you are going though.

Here also second approach, we can use simple number for key at simple list, but for group list we can use key like ${groupIndex}_${index}

I think we need to study PrimeVue they actually do this: https://github.com/primefaces/primevue/blob/344ec64cd461aad1493073dd3ff10bc8a7338654/components/lib/dropdown/Dropdown.vue#L879-L888

And the Groups are actually a different type of Option that has result.push({ optionGroup: option, group: true, index }); so they index everything properly in getVisibleOptions

https://github.com/primefaces/primevue/blob/344ec64cd461aad1493073dd3ff10bc8a7338654/components/lib/dropdown/Dropdown.vue#L902-L926

I think we need to study PrimeVue they actually do this: https://github.com/primefaces/primevue/blob/344ec64cd461aad1493073dd3ff10bc8a7338654/components/lib/dropdown/Dropdown.vue#L879-L888

And the Groups are actually a different type of Option that has result.push({ optionGroup: option, group: true, index }); so they index everything properly in getVisibleOptions

https://github.com/primefaces/primevue/blob/344ec64cd461aad1493073dd3ff10bc8a7338654/components/lib/dropdown/Dropdown.vue#L902-L926

Should I try to apply it the way it's done in vue example?

Yes we should see if we can modify things the Vue way. If you try the Vue showcase the Dropdown with Groups is working fine: https://primevue.org/dropdown/#group

Yes we should see if we can modify things the Vue way. If you try the Vue showcase the Dropdown with Groups is working fine: https://primevue.org/dropdown/#group

Okey ill take a look

@melloware Vue Dropdown will flat all this to single options list first, and then all logic will work with this flatted list, But the React Dropdown component use the same format as it was passed and functions are not able to work with this type of data, also DropdownPanel is designed to handle groups the way they are, however still has an issue with indexses.I guess we can achieve the similar behaviour to Vue. Let me keep working

Yes I saw that. I feel like Vue is doing it a cleaner way and we just need to tweak the React code to do the same thing. I think DropDownPanel will need some changes but I think in the long run this will be better.

Wow this is looking so much cleaner!

Oh run npm run format on the code.