From 8dc9395aaf59a1388fd204dfef3b2711e4c0274e Mon Sep 17 00:00:00 2001 From: cassenhp <152225267+cassenhp@users.noreply.github.com> Date: Thu, 18 Jan 2024 15:11:32 -0700 Subject: [PATCH] Update ColumnFilter.js to allow clear button to show when menu button is hidden Fixed Issue where clear button will not be rendered if menu button is not rendered. In original issue fix listed below, I think that the check implemented in this issue was unintentionally placed in the createClearButton method In reference to this issue: https://github.com/primefaces/primereact/issues/4994 And this commit: https://github.com/primefaces/primereact/commit/deec2b2db26ebcfc98f56ba6b9cd2c31d6ac3b69 --- components/lib/datatable/ColumnFilter.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/components/lib/datatable/ColumnFilter.js b/components/lib/datatable/ColumnFilter.js index 50e3e27a21..da55f73e8e 100644 --- a/components/lib/datatable/ColumnFilter.js +++ b/components/lib/datatable/ColumnFilter.js @@ -563,10 +563,6 @@ export const ColumnFilter = React.memo((props) => { }; const createClearButton = () => { - if (!showMenuButton()) { - return null; - } - const filterClearIconProps = mergeProps( { 'aria-hidden': true