Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second Sidebar reset blockScroll #910

Closed
user753 opened this issue Jun 4, 2019 · 3 comments
Closed

Second Sidebar reset blockScroll #910

user753 opened this issue Jun 4, 2019 · 3 comments
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@user753
Copy link

user753 commented Jun 4, 2019

    <Sidebar blockScroll={true}>
        Sidebar1
    </Sidebar>
    <Sidebar blockScroll={true}>
        Sidebar2
    </Sidebar>

When I open first Sidebar and then open and close second Sidebar the blockScroll stops working.

"primereact": "^3.1.3",
"react": "^16.8.6",
@mertsincan
Copy link
Member

I couldn't replicate it. Could you please attach a codesandbox link for us to replicate?

https://codesandbox.io/s/qjx332qq4

Also, you need to use onHide func for Sidebars. It is required.

 onHide: PropTypes.func.isRequired

Best Regards,

@mertsincan mertsincan self-assigned this Jun 21, 2019
@mertsincan mertsincan added the Resolution: Cannot Replicate Issue could not be replicated by Core Team label Jun 21, 2019
@user753
Copy link
Author

user753 commented Jun 21, 2019

@mertsincan https://codesandbox.io/s/primereact-test-6w7x2

@mertsincan
Copy link
Member

Fixed now, thanks a lot ;)

@mertsincan mertsincan added Type: Bug Issue contains a defect related to a specific component. and removed Resolution: Cannot Replicate Issue could not be replicated by Core Team labels Jun 21, 2019
@mertsincan mertsincan added this to the 3.1.5 milestone Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

2 participants