Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong type for showWeek in Calendar.d.ts #907

Closed
Bublade opened this issue May 31, 2019 · 3 comments
Closed

Wrong type for showWeek in Calendar.d.ts #907

Bublade opened this issue May 31, 2019 · 3 comments
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@Bublade
Copy link

Bublade commented May 31, 2019

I'm submitting a ...

[X] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

wrong type used:
Calendar.d.ts >CalendarProps > showWeek

/**56**/    showWeek: PropTypes.bool, // <-- line endig is wrong also.

it should be:

/**56**/    showWeek?: boolean;

Current behavior
Compile error.

Expected behavior
No compile errors

Minimal reproduction of the problem with instructions

  1. Render a Calendar component without giving props
  2. An error shows up.
  3. npm start gives compile errors on other places where you use a Calendar.

Please tell us about your environment:
VSCode, Windows 10

  • React version:
    16.6.3

  • PrimeReact version:
    3.1.4

  • Browser: all

  • Language: TypeScript 3.4.5

@BuckAMayzing
Copy link

Same. This seems to be an issue with 3.1.4 specifically. 3.1.3 is not having the same problem.

@Bublade
Copy link
Author

Bublade commented Jun 4, 2019

1baaa78#diff-64a1af23e8085e20e2de09c527457b8c

its been something they added in 3.1.4

@mertsincan mertsincan self-assigned this Jun 21, 2019
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Jun 21, 2019
@mertsincan mertsincan added this to the 3.1.5 milestone Jun 21, 2019
@mertsincan
Copy link
Member

mertsincan commented Jun 21, 2019

Fixed now, thanks a lot ;)

showWeek?: boolean;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

3 participants