Calendar: onSelect is forcing date while typing

[manuel-bitcraft]

Describe the bug

Adding the onSelect callback (even an empy function) changes the typing behaviour for the date.

Reproducer

https://stackblitz.com/edit/dppelmek?file=src%2FApp.jsx

System Information

System:
    OS: Windows 11 10.0.22631
    CPU: (12) x64 13th Gen Intel(R) Core(TM) i7-1355U
    Memory: 41.48 GB / 63.64 GB
  Binaries:
    Node: 18.20.4 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.22 - C:\Program Files\nodejs\yarn.CMD
    npm: 10.7.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Chromium (128.0.2739.67)
    Internet Explorer: 11.0.22621.3527
  npmPackages:
    primereact: ^10.8.5 => 10.8.5 
    react: ^18 => 18.2.0 
    tailwindcss: ^3.3.0 => 3.4.1

Steps to reproduce the behavior

Notes: using format dd/mm/yy
Objective: select date 15/01/2025 and then modify date to '15/11/2025' by typing

With onSelect commented out

1. Select date 15/01/2025
2. Place cursor after month (01)
3. Press backspace twice so date reads '15//2025'
4. type 1 so the date reads '15/1/2025'
5. type 1 againg so date reads '15/11/2025'
6. Success

With onSelect enabled as an empty callback

1. Select date 15/01/2025
2. Place cursor after month (01)
3. Press backspace twice so date reads '15//2025'
4. as soon as you type 1, the date changes to '15/01/2025' and the cursor is moved at the end
5. if you try to delete the '0' for the '01' month (so I can type 1 to set the month to 11), the date stays to '15/01/2025' and the cursor is moved at the end
6. Failed

Expected behavior

No response

[melloware]

looks like its related to this fix: #7121

[KumJungMin]

• I have checked the issue :)
• As a result, I found that the same problem occurs in the previous version (v10.8.3) as well 😢
• After investigating the cause of the issue, I discovered that the onSelect event is triggered when typing in the input field.

primereact/components/lib/calendar/Calendar.js

Lines 140 to 141 in a7c99b3

	const onUserInput = (event) => {
	updateValueOnInput(event, event.target.value);

issue occurred flow (Versions prior to v10.8.3)

graph TD
    A[User types in input field] --> B[onUserInput function is triggered]
    B --> C[updateValueOnInput function is triggered]
    C --> D[updateViewDate function is triggered]
    D --> E[onSelect function is triggered]
    E --> F["Issue occurred!!"] 

Loading

• For now, I submitted a PR under the assumption that the onSelect function should only be triggered when clicking the date button.
• This ensures that the onSelect function does not execute while the user is typing.
• If the onSelect function is also expected to work while typing in the input field,
• please leave a comment, and I will update it accordingly. Thank you! 😄

[melloware]

Nice it looks like this was introduced in #7155