Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DropdownItem: Error: "key" prop is being spread into JSX #7430

Closed
tneeraja95 opened this issue Nov 18, 2024 · 0 comments · Fixed by #7431
Closed

DropdownItem: Error: "key" prop is being spread into JSX #7430

tneeraja95 opened this issue Nov 18, 2024 · 0 comments · Fixed by #7431
Assignees
@tneeraja95
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.8.5

Comments

@tneeraja95
Copy link
Contributor

Describe the bug

Inside DropdownItem, which is a item in the dropdown list, so key is required prop.

Screenshot 2024-11-18 at 8 01 17 PM

Inside DropdownItem.js, key is in itemProps which should be outside and directly in <li>

Reproducer

https://stackblitz.com/edit/xqgdym?file=src%2FApp.jsx

System Information

react : "18.3.1"
primereact: "10.8.4"

Steps to reproduce the behavior

  1. Open inspect
  2. Click on the dropdown
  3. Can see error in console.

Expected behavior

No error
@tneeraja95 tneeraja95 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 18, 2024
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 18, 2024
@tneeraja95 tneeraja95 mentioned this issue Nov 18, 2024
Merged
@melloware melloware added this to the 10.8.5 milestone Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tneeraja95 tneeraja95

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.8.5
Development

Successfully merging a pull request may close this issue.

Fix: Dropdowmitem: Passing key directly without using spread tneeraja95/primereact
2 participants
@melloware @tneeraja95