Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need event inside the onHide callback #7393

Closed
snake-py opened this issue Nov 5, 2024 · 0 comments · Fixed by #7394
Closed

Need event inside the onHide callback #7393

snake-py opened this issue Nov 5, 2024 · 0 comments · Fixed by #7394
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@snake-py
Copy link
Contributor

snake-py commented Nov 5, 2024

Describe the bug

I have a dialog implemented which basically react to the url changes. e.g. ?showDialog=true would open the dialog while ?showDialog=false will close it. The main issue is now if the user uses browser back, the onHide is called. However in my close funciton I also modify the url params (update the history). So basically I want to be able to tell where the close event came from and adjust my logic based on the event origin.

Reproducer

No response

System Information

Ubuntu

Steps to reproduce the behavior

No response

Expected behavior

Getting an event inside the callback https://primereact.org/dialog/#api.Dialog.callbacks.onHide

@snake-py snake-py added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 5, 2024
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 5, 2024
@melloware melloware added this to the 10.8.5 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants