Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance accessibility for Checkbox with ARIA roles #729

Closed
keul opened this issue Jan 8, 2019 · 1 comment
Closed

Enhance accessibility for Checkbox with ARIA roles #729

keul opened this issue Jan 8, 2019 · 1 comment
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@keul
Copy link
Contributor

keul commented Jan 8, 2019

I'm submitting a ... (check one with "x")

[ ] bug report
[x] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Current behavior

The Checkbox element is accessible using keyboard and provide focus behavior, but there's no usage of ARIA roles. See https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/checkbox_role

Expected behavior
Add ARIA role to Checkbox's div:

<div class="p-checkbox-box p-component p-highlight" role="checkbox" aria-checked="true">
...

Also: the Checbkox component (maybe lot of other orimereact components) should accept and render a aria-labelledby attribute in case the user provide it.

@cagataycivici cagataycivici self-assigned this Jan 10, 2019
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jan 10, 2019
@cagataycivici cagataycivici added this to the 3.0.0-rc.1 milestone Jan 10, 2019
@efc
Copy link

efc commented Apr 7, 2019

Please note that this issue was closed even though the aria-labelledby attribute has not been implemented for prime-react input components. I need this to implement special labels for some Dropdown components, for example. I've opened issue #839 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

3 participants