Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog: does not close when clicking on Esc #6717

Closed
leevva opened this issue Jun 3, 2024 · 0 comments · Fixed by #6719
Closed

Dialog: does not close when clicking on Esc #6717

leevva opened this issue Jun 3, 2024 · 0 comments · Fixed by #6719
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.7.0

Comments

@leevva
Copy link

leevva commented Jun 3, 2024 •
edited
Loading

Describe the bug

After opening the dialog, the Escape button does not work. It doesn't close the dialog.
You can see this on demo site: https://primereact.org/dialog/
It worked on 10.6.5.

Reproducer

No response

PrimeReact version

10.6.6

React version

18.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@leevva leevva added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 3, 2024
@navedqb navedqb mentioned this issue Jun 3, 2024
Merged
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jun 3, 2024
@melloware melloware added this to the 10.7.0 milestone Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.7.0
Development

Successfully merging a pull request may close this issue.

fix: escape key not working in dialog qburst/primereact-1
2 participants
@melloware @leevva