Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot read property 'dayNamesShort' of undefined #647

Closed
muxahuk opened this issue Nov 20, 2018 · 1 comment
Closed

cannot read property 'dayNamesShort' of undefined #647

muxahuk opened this issue Nov 20, 2018 · 1 comment
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@muxahuk
Copy link

muxahuk commented Nov 20, 2018

There is no guarantee in receiving an immediate response in GitHub Issue Tracker, If you'd like to secure our response, you may consider PrimeReact PRO Support where support is provided within 4 business hours

I'm submitting a ... (check one with "x")

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Plunkr Case (Bug Reports)
Please fork the plunkr below and create a case demonstrating your bug report. Issues without a plunkr have much less possibility to be reviewed.

https://plnkr.co/edit/VxdOaW4U5h2cz19CMb2Y?p=preview

Current behavior
Errors in console, at least my application if broken

Expected behavior
Should not have errors

Minimal reproduction of the problem with instructions

  • use primereact/components/calendar/Calendar Calendar component.
  • In dateFormat use capital D or M for ex. D d/M/y

Please tell us about your environment:
Ubuntu 18.4, npm, react-create-app dev server

  • React version:
    ^16.4.1

  • PrimeReact version:
    ^1.6.2

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
    Chromium (have not tested other browsers)

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    ES6/7 (but should be on all)

I was able to fix the issue by replacing this.locale... to this.props.locale... in Calendar component

as far as i see it was fixed here #456

but i don't see that v1.6.3 was ever released with the fix..

@Merve7 Merve7 self-assigned this Nov 27, 2018
@Merve7 Merve7 added this to the 2.0.0-rc.1 milestone Nov 27, 2018
@Merve7 Merve7 added the Type: Bug Issue contains a defect related to a specific component. label Nov 27, 2018
@Merve7 Merve7 closed this as completed in 57c5bc9 Nov 27, 2018
@muxahuk
Copy link
Author

muxahuk commented Nov 27, 2018

Is there any chance you will release v1.6.3 with the fix?

@Merve7 Merve7 modified the milestones: 2.0.0-rc.1, 2.0.0 Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

2 participants