Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FloatLabel: wrong type #6299

Closed
maitrungduc1410 opened this issue Apr 4, 2024 · 3 comments
Closed

FloatLabel: wrong type #6299

maitrungduc1410 opened this issue Apr 4, 2024 · 3 comments
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component. Typescript Issue or pull request is *only* related to TypeScript definition
Milestone
10.6.4

Comments

@maitrungduc1410
Copy link

maitrungduc1410 commented Apr 4, 2024 •
edited
Loading

Describe the bug

when I use FloatLabel, typescript is showing typecheck error though no issue at runtime

<FloatLabel>
  <InputText  />
  <label htmlFor="username">Username</label>
</FloatLabel>
Screenshot 2024-04-04 at 3 07 28 PM

And in console I also see this error:
Screenshot 2024-04-04 at 3 09 11 PM

Reproducer

No response

PrimeReact version

10.6.0

React version

18.x

Language

TypeScript

Build / Runtime

Next.js

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@maitrungduc1410 maitrungduc1410 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 4, 2024
@melloware
Copy link
Member

Duplicate of: #6268

Fixed for next release.

@melloware melloware added Resolution: Duplicate Issue has already been reported or a pull request related to same issue has already been submitted and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 4, 2024
@melloware melloware added this to the 10.6.3 milestone Apr 4, 2024
@melloware melloware closed this as not planned Won't fix, can't repro, duplicate, stale Apr 4, 2024
@gucal gucal removed this from the 10.6.3 milestone Apr 9, 2024
@rjahn
Copy link

rjahn commented Apr 19, 2024

This problem is not fixed in https://github.com/primefaces/primereact/releases/tag/10.6.3 and it doesn't look like a duplicate of #6268 ?

I use 10.6.3 and have the same error message:

Type '{ children: Element[]; }' has no properties in common with type 'IntrinsicAttributes & FloatLabelProps & RefAttributes'.

Can't run the application and can't build it.

@melloware melloware reopened this Apr 19, 2024
@melloware melloware added Typescript Issue or pull request is *only* related to TypeScript definition and removed Resolution: Duplicate Issue has already been reported or a pull request related to same issue has already been submitted labels Apr 19, 2024
@melloware melloware added this to the 10.6.4 milestone Apr 19, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 19, 2024
@melloware melloware self-assigned this Apr 19, 2024
@melloware melloware removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 19, 2024
@melloware
Copy link
Member

Dupe of this one fixed for 10.6.4: #6387

@nitrogenous nitrogenous added the Type: Bug Issue contains a defect related to a specific component. label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component. Typescript Issue or pull request is *only* related to TypeScript definition
Projects
None yet
Milestone
10.6.4
Development

No branches or pull requests
5 participants
@rjahn @melloware @maitrungduc1410 @nitrogenous @gucal