Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Unstyled property does not inherit to children #6142

Closed
vaelu opened this issue Mar 13, 2024 · 2 comments · Fixed by #6286
Closed

Core: Unstyled property does not inherit to children #6142

vaelu opened this issue Mar 13, 2024 · 2 comments · Fixed by #6286
Assignees
Labels
Component: Unstyled Issue related to unstyled/passthrough attributes
Milestone

Comments

@vaelu
Copy link
Contributor

vaelu commented Mar 13, 2024

Describe the bug

We are using unstyled mode without a provider, so setting it directly on component basis, e.g.:

import { FileUpload } from "primereact/fileupload";
import TailwindDefaultPT from "primereact/passthrough/tailwind";

return <FileUpload unstyled pt={TailwindDefaultPT.fileupload} />;

Unfortunately, the components which are re-using other components inside (for example FileUpload, which re-uses the Button component inside), do not inherit the unstyled property, which causes that the buttons (only the upload and cancel button in this example, the choose button is not using the Button component, who knows why..) still have the p- classes (e.g.: p-component p-button etc.)

Please check the StackBlitz example. The problem exists on all components, not only on this one.

Reproducer

https://stackblitz.com/edit/rucqxs?file=src%2FApp.jsx

PrimeReact version

10.5.1

React version

18.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@vaelu vaelu added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 13, 2024
@melloware melloware added Component: Unstyled Issue related to unstyled/passthrough attributes and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 13, 2024
@melloware melloware changed the title All components: Unstyled property does not inherit to children components when set as property Core: Unstyled property does not inherit to children components when set as property Mar 13, 2024
@melloware melloware changed the title Core: Unstyled property does not inherit to children components when set as property Core: Unstyled property does not inherit to children Mar 13, 2024
@vaelu
Copy link
Contributor Author

vaelu commented Mar 26, 2024

@melloware is there any update on this issue? is it already known by the team?

@melloware
Copy link
Member

No update. If you need immediate support I suggest you look into PrimeReact PRO support: https://primereact.org/support/

Other than that you are at the mercy of the open source community and when they get to it...

@nitrogenous nitrogenous reopened this Apr 2, 2024
@nitrogenous nitrogenous self-assigned this Apr 2, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 2, 2024
@nitrogenous nitrogenous linked a pull request Apr 2, 2024 that will close this issue
@melloware melloware removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 2, 2024
@melloware melloware added this to the 10.6.3 milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Unstyled Issue related to unstyled/passthrough attributes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants