Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable: need to be converted to data- lookups instead of className lookups #5524

Closed
kl-nevermore opened this issue Dec 5, 2023 · 3 comments · Fixed by #5532
Closed

DataTable: need to be converted to data- lookups instead of className lookups #5524

kl-nevermore opened this issue Dec 5, 2023 · 3 comments · Fixed by #5532
Assignees
@kl-nevermore
Labels
Component: Tailwind Tailwind specific issue
Milestone
10.3.0

Comments

@kl-nevermore
Copy link
Contributor

Describe the bug

In unstyled mode,comp don't have classname,so need to be converted to data- lookups instead of className lookups

Reproducer

No response

PrimeReact version

latest

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@kl-nevermore kl-nevermore added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 5, 2023
@melloware melloware added Component: Tailwind Tailwind specific issue and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 5, 2023
@kl-nevermore
Copy link
Contributor Author

I can submit a draft pr tomorrow for DataTable, Resize related things have not been completed yet

@melloware
Copy link
Member

Ok great!

@kl-nevermore kl-nevermore mentioned this issue Dec 6, 2023
Merged
@kl-nevermore
Copy link
Contributor Author

TreeTable create new pr when I'm done

@kl-nevermore kl-nevermore changed the title Table: need to be converted to data- lookups instead of className lookups DataTable: need to be converted to data- lookups instead of className lookups Dec 6, 2023
@melloware melloware added this to the 10.2.2 milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kl-nevermore kl-nevermore

Labels
Component: Tailwind Tailwind specific issue
Projects
None yet
Milestone
10.3.0
Development

Successfully merging a pull request may close this issue.

DataTable:converted to data- lookups instead of className lookups
2 participants
@melloware @kl-nevermore