Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

originalEvent in TabView has swapped typing/variable name in TabView.d.ts #528

Closed
prozacgod opened this issue Aug 7, 2018 · 1 comment
Closed
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@prozacgod
Copy link

prozacgod commented Aug 7, 2018

This needs to be fixed, I'd happily provide a pull request, but am unavailable to do so at the moment.

interface TabViewProps {
    id?: string;
    activeIndex?: number;
    style?: any;
    className?: string;
    // this is swapped here
    onTabChange?(e: {originalEvent:Event, index: number}): void;
}
@cagataycivici cagataycivici self-assigned this Aug 22, 2018
@cagataycivici cagataycivici added the Type: Bug Issue contains a defect related to a specific component. label Aug 22, 2018
@cagataycivici cagataycivici added this to the 2.0.0-beta.2 milestone Aug 22, 2018
@cagataycivici
Copy link
Member

cagataycivici commented Aug 22, 2018

It is currently;

onTabChange?(e: {originalEvent: Event, index: number}): void;

So fixed already via #525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

2 participants