Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailwind: MultiSelect: multiple conflicting classname keys #5200

Closed
gcko opened this issue Oct 31, 2023 · 1 comment · Fixed by #5201
Closed

Tailwind: MultiSelect: multiple conflicting classname keys #5200

gcko opened this issue Oct 31, 2023 · 1 comment · Fixed by #5201
Assignees
Labels
Component: Tailwind Tailwind specific issue
Milestone

Comments

@gcko
Copy link
Contributor

gcko commented Oct 31, 2023

Describe the bug

There are two conflicting keys using similar properties for multiselect's label:

{
    '!p-3': props.display !== 'chip' && (props?.modelValue == null || props?.modelValue == undefined), // <--- First
    '!py-1.5 px-3': props.display == 'chip' && props?.modelValue !== null,
    '!p-3': props.display == 'chip' && props?.modelValue == null <--- Duplicate
}

Reproducer

No response

PrimeReact version

10.0.7

React version

18.x

Language

TypeScript

Build / Runtime

Next.js

Browser(s)

No response

Steps to reproduce the behavior

  1. Navigate to components/lib/passthrough/tailwind/index.js
  2. Note the duplicate lines

Expected behavior

There should only be one line

@gcko gcko added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 31, 2023
@melloware melloware added Component: Tailwind Tailwind specific issue and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 31, 2023
@melloware melloware added this to the 10.0.8 milestone Oct 31, 2023
@melloware
Copy link
Member

Thanks for the PR! Keep em coming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Tailwind Tailwind specific issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants